Conversation
added pip install --break-system-packages v${MINIPOLISH_VER}.tar.gz && \
|
Looks like this one failed |
|
Oh weird. I will look into the error. Could it be that the samples used to test are not good anymore? |
The very last line is the new code to test and try without a wrapper script
|
@erinyoung where did you get that output from? I want to make sure I can replicate the error to debug it. Was it when you ran the docker? I made a small update and my docker build ran fine again: |
|
I would recommend you go into your docker image after you build it and see the output. The text I copy into these PR are the results from the GitHub Actions (GA). The link is https://github.com/StaPH-B/docker-builds/actions/runs/23016665625/job/66841744349?pr=1592 |
|
So it appears my code fix worked! After I ran the image and checked it looks like all the tests were successful. |
|
You are completely correct! It looks like it's working now |
erinyoung
left a comment
There was a problem hiding this comment.
I have no changes to recommend. I'll get this merged and deployed.
|
You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/23060171280 |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Description
Updated minipolish to 0.2.1 version from 0.2.0
Diff Output
Test build